Skip to content

Minor: make some physical-plan properties public#12022

Merged
alamb merged 4 commits intoapache:mainfrom
emgeee:functions-pub
Aug 17, 2024
Merged

Minor: make some physical-plan properties public#12022
alamb merged 4 commits intoapache:mainfrom
emgeee:functions-pub

Conversation

@emgeee
Copy link
Copy Markdown
Contributor

@emgeee emgeee commented Aug 15, 2024

Which issue does this PR close?

Closes #12021

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

No

@github-actions github-actions Bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Aug 15, 2024
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @emgeee

Comment thread datafusion/physical-plan/src/aggregates/mod.rs Outdated
}
}

impl Default for GroupOrderingFull {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @emgeee

@alamb alamb merged commit 186ba4c into apache:main Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make properties in phyiscal-plan/aggregates public

2 participants