Skip to content

Fix: support NULL input for like operations #12025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dandandan merged 1 commit into from
Aug 16, 2024
Merged

Fix: support NULL input for like operations #12025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafusion/expr-common/src/type_coercion/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,7 @@ pub fn like_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataTyp
.or_else(|| list_coercion(lhs_type, rhs_type))
.or_else(|| binary_to_string_coercion(lhs_type, rhs_type))
.or_else(|| dictionary_coercion(lhs_type, rhs_type, false))
.or_else(|| regex_null_coercion(lhs_type, rhs_type))
.or_else(|| null_coercion(lhs_type, rhs_type))
}

Expand Down
20 changes: 20 additions & 0 deletions datafusion/sqllogictest/test_files/regexp.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,26 @@ SELECT 'foo\nbar\nbaz' LIKE '%bar%';
----
true

query B
SELECT NULL LIKE NULL;
----
NULL

query B
SELECT NULL iLIKE NULL;
----
NULL

query B
SELECT NULL not LIKE NULL;
----
NULL

query B
SELECT NULL not iLIKE NULL;
----
NULL

statement ok
drop table t;

Expand Down