Skip to content

Minor: cleanup .gitignore#12035

Merged
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/clean_gitignore
Aug 16, 2024
Merged

Minor: cleanup .gitignore#12035
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/clean_gitignore

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Aug 16, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

While working on #12034 I noticed a bunch of stuff in .gitignore that was left over from when this code was pulled from the arrow monorepo: https://github.com/apache/arrow/blob/main/.gitignore

What changes are included in this PR?

Remove the obviously irrelevant parts of .gitignore

I am sure there is more we could remove but this is an improvement already in my mind

Are these changes tested?

Sort of by CI

Are there any user-facing changes?

No, this is entirely development process changes

@alamb alamb added the development-process Related to development process of DataFusion label Aug 16, 2024
@github-actions github-actions Bot removed the development-process Related to development process of DataFusion label Aug 16, 2024
Copy link
Copy Markdown
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb I think those files been added by members compiing the project under different OSs and IDEs. But I agree the local copy of .gitignore should reflect their needs

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Aug 16, 2024

If someone needs additional lines in .gitignore to help their workflow I think we should definitely merge them in -- there is no harm in having more stuff in here.

@alamb alamb merged commit dc84fa5 into apache:main Aug 16, 2024
@alamb alamb deleted the alamb/clean_gitignore branch August 16, 2024 15:38
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Aug 16, 2024

Thanks @comphead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants