-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add untyped null #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add untyped null #1212
Conversation
|
I am not sure anymore this is a good idea. The problem with introducing |
|
That's a good point @Dandandan |
The alternative I think is to infer types for null during planning |
|
I think that during planning we should treat the type of any @jimexist I think added the needed casting logic in arrow-rs at apache/arrow-rs#884 (though that didn't make it into 6.1.0 -- so I suppose we have to wait a bit longer -- though maybe I'll end up making a 6.2.0 before 6.1.0 gets through the voting process 🤣 ) Once we can cast from |
|
any progress, is there any context or doc for this? |
|
I had effectively changed Now I think we have those kernels it would be useful to try again -- but I am not sure when I will have the time again |
|
I am trying to clean up the list of PRs to review in DataFusion so marking old ones as stale. Please let us know if you plan to work on this soon. Otherwise we will close it down and reopen it when the time is right. |
|
Closing stale PRs, please reopen if this was a mistake and you plan to keep working on this one |
…1242) * Fix drop() method to handle quoted column names consistently - Strip quotes from column names in drop() method - Maintains consistency with other DataFrame operations - Both drop('col') and drop('col') now work Fixes apache#1212 * Update drop() method docstring to clarify quote handling - Document that column names are case-sensitive and don't require quotes - Clarify that both quoted and unquoted column names are accepted - Add examples showing both 'col' and 'col' syntax work - Note difference from select() operation behavior * Fix whitespace and documentation errors --------- Co-authored-by: Tim Saucer <timsaucer@gmail.com>
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?