Support map_keys & map_values for MAP type

[dharanad]

Which issue does this PR close?

Closes #12147 & #12148

Rationale for this change

What changes are included in this PR?

• Added map_keys & map_values scalar function. Ref : https://duckdb.org/docs/sql/functions/map.html#map_valuesmap

Are these changes tested?

Are there any user-facing changes?

[dharanad]

Encounter a bug. Fixed it by changing field name to item. But why ?

Internal error: Failed due to a difference in schemas, original schema: DFSchema { inner: Schema { fields: [Field { name: "map_keys(map(make_array(Int64(1),Int64(2),Int64(3)),make_array(Int64(1),Int64(2),Int64(3))))", data_type: List(Field { name: "keys", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers: [None], functional_dependencies: FunctionalDependencies { deps: [] } }, new schema: DFSchema { inner: Schema { fields: [Field { name: "map_keys(map(make_array(Int64(1),Int64(2),Int64(3)),make_array(Int64(1),Int64(2),Int64(3))))", data_type: List(Field { name: "item", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers: [None], functional_dependencies: FunctionalDependencies { deps: [] } }.

[Weijun-H]

Encounter a bug. Fixed it by changing field name to item. But why ?

Internal error: Failed due to a difference in schemas, original schema: DFSchema { inner: Schema { fields: [Field { name: "map_keys(map(make_array(Int64(1),Int64(2),Int64(3)),make_array(Int64(1),Int64(2),Int64(3))))", data_type: List(Field { name: "keys", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers: [None], functional_dependencies: FunctionalDependencies { deps: [] } }, new schema: DFSchema { inner: Schema { fields: [Field { name: "map_keys(map(make_array(Int64(1),Int64(2),Int64(3)),make_array(Int64(1),Int64(2),Int64(3))))", data_type: List(Field { name: "item", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, field_qualifiers: [None], functional_dependencies: FunctionalDependencies { deps: [] } }.

I think it is caused by the pre-defined field name in make_array.

datafusion/datafusion/functions-nested/src/map.rs

Lines 33 to 39 in 7e9ea3a

	/// Returns a map created from a key list and a value list
	pub fn map(keys: Vec<Expr>, values: Vec<Expr>) -> Expr {
	let keys = make_array(keys);
	let values = make_array(values);
	Expr::ScalarFunction(ScalarFunction::new_udf(map_udf(), vec![keys, values]))
	}

[Weijun-H]

LGTM! Thanks @dharanad

[Weijun-H]

@dharanad could you add some doc for this function?

[dharanad]

Sorry for the mess, i thought since the change was similar for both map_keys && map_values why not club it.

[Weijun-H]

After fixing CI, it is ready to go

[dharanad]

After fixing CI, it is ready to go

@Weijun-H Any idea, how do i fix the docs formatting issue

[Weijun-H]

After fixing CI, it is ready to go

@Weijun-H Any idea, how do i fix the docs formatting issue

You could check here https://datafusion.apache.org/contributor-guide/howtos.html#how-to-format-md-document

[Weijun-H]

ship it!

[Weijun-H]

Thanks @dharanad contribution, and @Blizzara and @jayzhan211 for reviewing.

[dharanad]

Thank You @Weijun-H @jayzhan211 @Blizzara