Skip to content

Remove FileScanConfig::repartition_file_groups function #12242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Sep 1, 2024
Merged

Remove FileScanConfig::repartition_file_groups function #12242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions datafusion/core/src/datasource/physical_plan/file_scan_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ use std::{
borrow::Cow, collections::HashMap, fmt::Debug, marker::PhantomData, sync::Arc, vec,
};

use super::{
get_projected_output_ordering, statistics::MinMaxStatistics, FileGroupPartitioner,
};
use super::{get_projected_output_ordering, statistics::MinMaxStatistics};
use crate::datasource::{listing::PartitionedFile, object_store::ObjectStoreUrl};
use crate::{error::Result, scalar::ScalarValue};

Expand Down Expand Up @@ -296,19 +294,6 @@ impl FileScanConfig {
})
}

#[allow(missing_docs)]
#[deprecated(since = "33.0.0", note = "Use SessionContext::new_with_config")]
pub fn repartition_file_groups(
file_groups: Vec<Vec<PartitionedFile>>,
target_partitions: usize,
repartition_file_min_size: usize,
) -> Option<Vec<Vec<PartitionedFile>>> {
FileGroupPartitioner::new()
.with_target_partitions(target_partitions)
.with_repartition_file_min_size(repartition_file_min_size)
.repartition_file_groups(&file_groups)
}

/// Attempts to do a bin-packing on files into file groups, such that any two files
/// in a file group are ordered and non-overlapping with respect to their statistics.
/// It will produce the smallest number of file groups possible.
Expand Down