refactor(substrait): refactor ReadRel consumer #12983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
approved these changes
Oct 18, 2024
Contributor
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
One minor comment, but overall this looks good to me. Thanks for following up with the 🧹
| Ok(LogicalPlan::Values(Values { | ||
| schema: DFSchemaRef::new(substrait_schema), | ||
| values, | ||
| })) |
Contributor
There was a problem hiding this comment.
minor/non-blocking: strictly speaking, we should call read_with_schema here as well because it's valid to define a projection for a VirtualTable.
Contributor
Author
There was a problem hiding this comment.
That's a good point, but I think the implementation will have to be different. NamedTable and LocalFiles translate to TableScan operator which has a projections field that is used by read_with_schema function. VirtualTable translates to Values operator instead that doesn't have a projections field, we will have to apply a Project on top. I'll open a ticket to track this.
Contributor
|
🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
some minor refactoring after #12800 as promised.
Are these changes tested?
existing tests
Are there any user-facing changes?
no