improve the condition checking for unparsing table_scan #13062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
approved these changes
Oct 22, 2024
Contributor
phillipleblanc
left a comment
phillipleblanc
left a comment
There was a problem hiding this comment.
Thanks for the follow-on PR!
datafusion/sql/src/unparser/plan.rs
Outdated
| builder = builder.alias(alias.clone().unwrap())?; | ||
| if let Some(alias) = alias { | ||
| if table_scan.projection.is_none() && table_scan.filters.is_empty() { | ||
| builder = builder.alias(alias.clone())?; |
Contributor
There was a problem hiding this comment.
Suggested change
| builder = builder.alias(alias.clone())?; | |
| builder = builder.alias(alias)?; |
I don't believe this final clone is needed, since its the last place to use it.
Contributor
Author
There was a problem hiding this comment.
You're right. I missed this point. Thanks!
alamb
approved these changes
Oct 22, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @goldmedal and @phillipleblanc
Contributor
Author
|
Thanks @alamb @phillipleblanc @jonahgao 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It's a follow-up of #13006
Rationale for this change
What changes are included in this PR?
We missed the good suggestions from @phillipleblanc #13006 (comment)
They make sense to me 👍
Are these changes tested?
the original tests.
Are there any user-facing changes?
no