Skip to content

Conversation

@jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #13036.

Rationale for this change

What changes are included in this PR?

Added static special functions page for unnest

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanc-n -- we are so close.

I checked this out and built it locally.

cd docs
./build.sh
open build/html/index.html

One thing I noticed was that there was a missing index entry, so I took the liberty of pushing a commit to fix that.

cc @Omega359

```
> select * from foo;
+---------------------+
| column1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the column name to struct_field or something. It required for me to look into the example twice to figure our the column1 is actually a structure. Renaming a column will make the example more intuitive

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea --done in 777f58d


# Special Functions

## Expansion Functiions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tpyo

@alamb
Copy link
Contributor

alamb commented Oct 26, 2024

Thanks @jonathanc-n and @comphead for the careful review.

@Omega359 we are very close to finishing!

@alamb alamb merged commit 22a242c into apache:main Oct 26, 2024
@jonathanc-n jonathanc-n deleted the add-special-functions branch November 6, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Add section or page for special functions

4 participants