Minor: make Expr::volatile infallible
#13206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
peter-toth
approved these changes
Oct 31, 2024
Contributor
peter-toth
left a comment
peter-toth
left a comment
There was a problem hiding this comment.
LGTM, this looks like the same idea as #13128 (comment)
findepi
approved these changes
Oct 31, 2024
| /// | ||
| /// See [`Volatility`] for more information. | ||
| pub fn is_volatile(&self) -> bool { | ||
| self.exists(|expr| Ok(expr.is_volatile_node())).unwrap() |
Member
There was a problem hiding this comment.
Add code comment why unwrap is safe here.
btw maybe we can have exists variant which doesn't throw?
Contributor
Author
There was a problem hiding this comment.
I will add the comment in a follow on PR The non fallable exists variant is an interesting idea -- maybe we can file a follow on issue for it
jonahgao
approved these changes
Nov 1, 2024
Contributor
Author
|
Thanks @findepi @peter-toth @jonahgao and @eejbyfeldt for the review -- I am going to merge this PR as it logically conflicts with #13128 so I can rebase that PR |
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to
Rationale for this change
While reviewing #13128 I noticed that the code got a bit more complicated because
Expr::volatilereturnsResult<bool>and thus the calling code needs now to pass upResultsHowever,
Expr::volatileis actually infallible (never returns an error) so let's mark it as such to keep the code simplerThis is also consistent with other
Exprmethods such asExpr::any_column_refsWhat changes are included in this PR?
Expr::volatileinfallibleAre these changes tested?
By existing CI
Are there any user-facing changes?
Expr::volatilehas changed