Revert "Improve push down filter of join (#13184)" #13229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ae1ccb.
github-actions
bot
added
optimizer
Dandandan
approved these changes
Nov 2, 2024
Contributor
|
Thanks -- merging quickly to get main to a releasable state. I think the plan to reopen the PR and keep working on it is great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7ae1ccb.
Which issue does this PR close?
Closes #13211
Rationale for this change
The pr #13184 introduced correctness issues. So lets revert it and then it can be reopen as a new PR with the issues fixed and improved tests.
What changes are included in this PR?
Revert of #13184
Are these changes tested?
Existing tests.
Are there any user-facing changes?
Fixes correctness issue.