Remove Expr clones from SortExprs
#13258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
peter-toth
force-pushed
the
remove-sort-expr-clones
branch
from
ed51689 to
3b598ec
Compare
peter-toth
force-pushed
the
remove-sort-expr-clones
branch
from
3b598ec to
47df15a
Compare
Contributor
Author
|
cc @findepi, @alamb, @crepererum |
alamb
approved these changes
Nov 5, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @peter-toth -- this looks very nice to me
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
Author
|
Thanks @alamb and @crepererum for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up of #12177, part of #12193.
Rationale for this change
Exprclones can be costly, so let's avoid them if we can.What changes are included in this PR?
This is a minor follow-up of #12177 to remove some
Exprclones.Are these changes tested?
Yes, with exiting UTs.
Are there any user-facing changes?
No.