Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 13, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

I was making an example for something and referring to date_bin docs and noticed it had no SQL example (and thus I also accidnetally mixed up the argument order)

https://datafusion.apache.org/user-guide/sql/scalar_functions.html#date-bin

Let's add one (mostly to save myself work in the future)

What changes are included in this PR?

Add an SQL example for date_bin:
Screenshot 2024-11-13 at 8 37 23 AM

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Nov 13, 2024
@github-actions github-actions bot added the functions Changes to functions implementation label Nov 13, 2024
Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm!

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alamb

@comphead comphead merged commit 042843a into apache:main Nov 13, 2024
@alamb alamb deleted the alamb/date_bin_doc branch November 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants