Set timezone for group column timestamp type #13535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Zhan <jayzhan211@gmail.com>
github-actions
bot
added
physical-expr
alamb
approved these changes
Nov 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211 -- this looks good to me
| /// `NULLABLE`: if the data can contain any nulls | ||
| #[derive(Debug)] | ||
| pub struct PrimitiveGroupValueBuilder<T: ArrowPrimitiveType, const NULLABLE: bool> { | ||
| data_type: DataType, |
Contributor
There was a problem hiding this comment.
I double checked and the single group by column implementation does the same thing
👍
adriangb
approved these changes
Nov 23, 2024
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
Looks great to me thank you for the quick fix!
Contributor
|
Thanks again @jayzhan211 and @adriangb |
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Jay Zhan <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13534.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?