[minor] Consolidate construction of the list field #13627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes the naming of the nested field implicit, and removes a bunch of item literals.
github-actions
bot
added
sql
findepi
approved these changes
Dec 3, 2024
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
as far as i verified this, only Field::new("item", .. are changed here.
Weijun-H
approved these changes
Dec 3, 2024
Contributor
|
🚀 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to
Fieldin a list arrow-rs#6784Rationale for this change
Make use of the implicit convention for nested list field names, and remove large number of
itemliterals throughout the code.What changes are included in this PR?
Use
Field::new_list_fieldinstead ofField::newwith explicititemname as the naming convention.Are these changes tested?
All existing tests pass.
Are there any user-facing changes?
None.