Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 7, 2021

Proposed cleanup I mentioned on #1387 (comment) (I mostly wanted to know if I had missed something in the review)

@alamb
Copy link
Contributor Author

alamb commented Dec 7, 2021

FYI @liukun4515

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice style, thanks @alamb

@houqp houqp added the development-process Related to development process of DataFusion label Dec 8, 2021
@houqp houqp merged commit 6450a8d into apache:master Dec 8, 2021
@alamb alamb deleted the alamb/cleanup branch December 8, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants