Skip to content

Bump rand to 0.9, rand_distr to 0.5.0, getrandom to 0.3.1#14447

Closed
mbrobbel wants to merge 7 commits intoapache:mainfrom
mbrobbel:rand
Closed

Bump rand to 0.9, rand_distr to 0.5.0, getrandom to 0.3.1#14447
mbrobbel wants to merge 7 commits intoapache:mainfrom
mbrobbel:rand

Conversation

@mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Feb 3, 2025

Which issue does this PR close?

Closes #14333.
Closes #14334.
Closes #14353.

Rationale for this change

https://rust-random.github.io/book/update-0.9.html

What changes are included in this PR?

The required changes to migrate from 0.8 to 0.9.

Are these changes tested?

CI.

Are there any user-facing changes?

No.

dependabot bot and others added 3 commits February 3, 2025 15:23
Updates the requirements on [rand](https://github.com/rust-random/rand) to permit the latest version.
- [Release notes](https://github.com/rust-random/rand/releases)
- [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md)
- [Commits](rust-random/rand@0.8.5...0.9.0)

---
updated-dependencies:
- dependency-name: rand
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [rand_distr](https://github.com/rust-random/rand) to permit the latest version.
- [Release notes](https://github.com/rust-random/rand/releases)
- [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md)
- [Commits](rust-random/rand@rand_distr-0.4.3...0.5.0)

---
updated-dependencies:
- dependency-name: rand_distr
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates core Core DataFusion crate common Related to common crate execution Related to the execution crate functions Changes to functions implementation labels Feb 3, 2025
@mbrobbel mbrobbel changed the title Bump rand to 0.9, rand_distr to 0.5.0 Bump rand to 0.9, rand_distr to 0.5.0, getrandom to 0.3.1 Feb 3, 2025
@mbrobbel
Copy link
Member Author

mbrobbel commented Feb 3, 2025

With the bump of rand we get getrandom@0.3.1 in our tree, for which we have to set the js_wasm feature (this was renamed) in datafusion/wasmtest. However we also have getrandom@0.2.15 via ahash, so we can't set the required feature for both these versions. Blocking this on tkaitchuck/aHash#251. Or we should forward the getrandom js feature in arrow? I'll take another look later.

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Apr 9, 2025
@github-actions github-actions bot closed this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate execution Related to the execution crate functions Changes to functions implementation physical-expr Changes to the physical-expr crates Stale PR has not had any activity for some time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant