Add test for nullable doesn't work when create memory table#14624
Merged
xudong963 merged 2 commits intoapache:mainfrom Feb 13, 2025
Merged
Add test for nullable doesn't work when create memory table#14624xudong963 merged 2 commits intoapache:mainfrom
xudong963 merged 2 commits intoapache:mainfrom
Conversation
comphead
reviewed
Feb 12, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
thanks @xudong963 would ddl.slt be a better place for the test?
alamb
approved these changes
Feb 12, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @xudong963
I agree with @comphead that ddl.slt would be a better location.
Member
Author
|
Thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add a test for #14522
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?