refactor: rm single_distinct_to_groupby optimizer pass
#15099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
reviewed
Mar 8, 2025
| // Filters can't be pushed down past Limits, we should do PushDownFilter after PushDownLimit | ||
| Arc::new(PushDownLimit::new()), | ||
| Arc::new(PushDownFilter::new()), | ||
| Arc::new(SingleDistinctToGroupBy::new()), |
Member
There was a problem hiding this comment.
Queries like avg(distinct a) rely on this rule, and without it, they cannot be executed anymore.
The following query is available on the main branch, but not on this PR branch.
DataFusion CLI v46.0.0
> select avg(distinct a) from values(1) t(a);
Execution error: avg(DISTINCT) aggregations are not available
Contributor
There was a problem hiding this comment.
The alternative would be to directly implement distinct support in the avg accumulator
The lack of avg support means we can't run multiple distinct avg aggregates
> select avg(distinct a), avg(distinct b) from values(1, 2) t(a, b);
Execution error: avg(DISTINCT) aggregations are not availableThis is tracked by
Contributor
There was a problem hiding this comment.
I also updated the ticket #2408 to explain the issue and a bit more about what is needed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14586 (comment) for benchmark and context
Which issue does this PR close?
Rationale for this change
This pass is no longer useful according to benchmark and may even slow down planning speed.
What changes are included in this PR?
single_distinct_to_groupbyoptimizer passAre these changes tested?
Yes
Are there any user-facing changes?
No