Merged
Conversation
github-actions
bot
added
optimizer
blaginin
approved these changes
Mar 19, 2025
Collaborator
blaginin
left a comment
blaginin
left a comment
There was a problem hiding this comment.
Thank you, looks nice! Left two small nits
| "+-------+", | ||
| ]; | ||
| assert_batches_eq!(expected, &result); | ||
| results.extend([result]); |
Collaborator
There was a problem hiding this comment.
Suggested change
| results.extend([result]); | |
| results.push(result); |
| ]; | ||
|
|
||
| assert_batches_sorted_eq!(expected, &read); | ||
| assert_snapshot!(batches_to_string(&read), @r" |
Collaborator
There was a problem hiding this comment.
i think we need
Suggested change
| assert_snapshot!(batches_to_string(&read), @r" | |
| assert_snapshot!(batches_to_sort_string(&read), @r" |
because it was assert_batches_sorted_eq before?
Contributor
Author
There was a problem hiding this comment.
I initially used batches_to_sort_string but it results in a different snapshot than expected:
+------+----+----+
| c1 | c2 | c3 |
+------+----+----+
| | 2 | 20 |
| Foo | 1 | 10 |
| bar | | |
+------+----+----+
So I went with batches_to_string
Collaborator
There was a problem hiding this comment.
got it! I think for this specific test it's okay - I don't see why it'd produce different sorted output. But in general it may be okay for you to rearrange the rows (#15312)
Contributor
Author
|
@blaginin Thanks for your review! I've updated the tests with the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #15282.
Rationale for this change
Make it easier to update string comparison tests.
What changes are included in this PR?
Adding
instato tests.Are these changes tested?
Are there any user-facing changes?
No.