-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Docs : Added Sql examples for window Functions : nth_val , etc
#15555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
i had done the changes required , we can move forward. |
|
hi @alamb could you trigger the CI for this ? |
nth_val , etc
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great -- thank you very much @Adez017 ❤️ -- nice first contribution!
|
It looks like there are a few small errors to fix to get a clean CI run |
|
hey @alamb , i'm pretty confused over here . could you please help to specify what is failing for ? |
|
i think it should work now . @alamb i think we can move forward for CI triggers |
|
I think there is an extra space that is causing the error in CI , although I had updated it @alamb it works now 😁 |
|
As i investigated what is causing the issue and I got that I forgot to add a new line in the end 😁. |
|
Thanks @Adez017 -- I ran |
|
does it now going to merge ? @alamb |
|
🚀 Thanks @Adez017 |
…che#15555) * add example for cum_dist * add nth_val examples * updated doc * updated nth_value * Update Nth_value * Update nth_value.rs * Update window_functions.md * Update window_functions.md * Update nth_value.rs * Updated nth_value.rs * fmt * Update via ./dev/update_function_docs.sh --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
nth_value, etc #13399What changes are included in this PR?
Added SQL examples for the window functions (
nth_value,cum_dist,etc)through the dynamically created docs##Rationale for this changes ?
Added the SQL example along with the syntax queries for the
nth_value,cum_dist. this give the user a context of how and when to use this queries along the given SQL query exmaple.