Skip to content

Conversation

@Adez017
Copy link
Contributor

@Adez017 Adez017 commented Apr 3, 2025

Which issue does this PR close?

What changes are included in this PR?

Added SQL examples for the window functions ( nth_value, cum_dist,etc)through the dynamically created docs

##Rationale for this changes ?
Added the SQL example along with the syntax queries for the nth_value,cum_dist . this give the user a context of how and when to use this queries along the given SQL query exmaple.

@github-actions github-actions bot added documentation Improvements or additions to documentation functions Changes to functions implementation labels Apr 3, 2025
@Adez017 Adez017 marked this pull request as draft April 3, 2025 11:59
@Adez017 Adez017 marked this pull request as ready for review April 3, 2025 12:56
@Adez017
Copy link
Contributor Author

Adez017 commented Apr 3, 2025

i had done the changes required , we can move forward.

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 3, 2025

hi @alamb could you trigger the CI for this ?

@alamb alamb changed the title Docs : Added Sql exmaples for window Functions : nth_val , etc Docs : Added Sql examples for window Functions : nth_val , etc Apr 3, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you very much @Adez017 ❤️ -- nice first contribution!

@alamb
Copy link
Contributor

alamb commented Apr 3, 2025

It looks like there are a few small errors to fix to get a clean CI run

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 4, 2025

hey @alamb , i'm pretty confused over here . could you please help to specify what is failing for ?

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 4, 2025

i think it should work now . @alamb i think we can move forward for CI triggers

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 4, 2025

I think there is an extra space that is causing the error in CI , although I had updated it @alamb it works now 😁

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 4, 2025

As i investigated what is causing the issue and I got that I forgot to add a new line in the end 😁.
i think it should work now

@alamb
Copy link
Contributor

alamb commented Apr 4, 2025

Thanks @Adez017 -- I ran cargo fmt and ./dev/update_function_docs.sh and checked in the resutl and pushed to this branch to try and get the tests passing

@Adez017
Copy link
Contributor Author

Adez017 commented Apr 5, 2025

does it now going to merge ? @alamb

@alamb
Copy link
Contributor

alamb commented Apr 5, 2025

🚀 Thanks @Adez017

@alamb alamb merged commit 5167a89 into apache:main Apr 5, 2025
29 checks passed
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
…che#15555)

* add example for cum_dist

* add nth_val examples

* updated doc

* updated nth_value

* Update Nth_value

* Update nth_value.rs

* Update window_functions.md

* Update window_functions.md

* Update nth_value.rs

* Updated nth_value.rs

* fmt

* Update via ./dev/update_function_docs.sh

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SQL examples to window functions: nth_value, etc

2 participants