Refactor regexp slt tests

[kumarlokesh]

Which issue does this PR close?

• Closes Update regexp slt tests to refactor out string type tests, cleanup #14452.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[comphead]

thanks @kumarlokesh I like it.
However my understanding was sqllogictest runner starts all files in parallel? do we have a guarantee data will be initiated before tests run?

[alamb]

FYI @Omega359 and @goldmedal -- do you have some time to review this PR?

[Omega359]

I'll take a look at this tomorrow

[Omega359]

???

[Omega359]

Beyond the addition of null into the test data as mentioned by @goldmedal I think this is a nice and clean refactor - thank you @kumarlokesh

[kumarlokesh]

Beyond the addition of null into the test data as mentioned by @goldmedal I think this is a nice and clean refactor - thank you @kumarlokesh

@Omega359 @goldmedal addressed above in 0c52058

[kumarlokesh]

thanks @kumarlokesh I like it. However my understanding was sqllogictest runner starts all files in parallel? do we have a guarantee data will be initiated before tests run?

@comphead my understanding is that when a test file includes another file using the include directive (like include ./init_data.slt.part), the sqllogictest runner would process this inclusion sequentially.
Thus, it's guaranteed that the included file's statements are executed in order, before continuing with the rest of the including file. This ensures that initialization data is properly set up before tests that depend on it are run.

Is this correct?

[kumarlokesh]

Seems like most recent pipeline failure is probably related to #15725. Waiting for this to merge.

[alamb]

Seems like most recent pipeline failure is probably related to #15725. Waiting for this to merge.

Merged!

[comphead]

@comphead my understanding is that when a test file includes another file using the include directive (like include ./init_data.slt.part), the sqllogictest runner would process this inclusion sequentially. Thus, it's guaranteed that the included file's statements are executed in order, before continuing with the rest of the including file. This ensures that initialization data is properly set up before tests that depend on it are run.

Is this correct?

Yeah, I think it is correct, include part makes a run sequence.

Btw I just went quickly through the sqllogic test runner, it looks like the init file will run as many times as it gets referenced, @Omega359 am I correct here?

[Omega359]

@comphead my understanding is that when a test file includes another file using the include directive (like include ./init_data.slt.part), the sqllogictest runner would process this inclusion sequentially. Thus, it's guaranteed that the included file's statements are executed in order, before continuing with the rest of the including file. This ensures that initialization data is properly set up before tests that depend on it are run.
Is this correct?

Yeah, I think it is correct, include part makes a run sequence.

Btw I just went quickly through the sqllogic test runner, it looks like the init file will run as many times as it gets referenced, @Omega359 am I correct here?

That is correct as far as I recall.

[comphead]

Thanks, As long as test and its dependencies runs in the separate context we are safe.

[comphead]

lgtm thanks @kumarlokesh

[goldmedal]

Thanks @kumarlokesh. look great 👍

[alamb]

❤️

[alamb]

Thank you so much @kumarlokesh @comphead and @goldmedal