benchmark: Support sort_tpch10 for benchmark #16671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Currently we only have sort_tpch for benchmark, recently when optimizing sort, i found sort_tpch10 will show more stable result sometimes, so i added this to benchmark script also.
cc @alamb @Dandandan
Rationale for this change
Sometimes, i found sort_tpch10 will get the more accurate or good result when we optimize the merge part, because our in_mem sort buffer is 1MB, so the sort_tpch will have less count for merge compare count, i added the sort_tpch10 to bench.sh, hope it will be helpful.
Currently we only have sort_tpch for benchmark, recently when optimizing sort, i found sort_tpch10 will show more stable result sometimes, so i added this to benchmark script also.
What changes are included in this PR?
Sometimes, i found sort_tpch10 will get the more accurate or good result when we optimize the merge part, because our in_mem sort buffer is 1MB, so the sort_tpch will have less count for merge compare count, i added the sort_tpch10 to bench.sh, hope it will be helpful.
Currently we only have sort_tpch for benchmark, recently when optimizing sort, i found sort_tpch10 will show more stable result sometimes, so i added this to benchmark script also.
Are these changes tested?
Yes
Are there any user-facing changes?
No