Use tokio::task::coop::poll_proceed by default in CooperativeStream #16748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
common
Contributor
Author
|
Draft status since this depends on the current git version of Tokio. Can be considered for merging after the next Tokio scheduled release. |
pepijnve
force-pushed
the
poll_proceed
branch
2 times, most recently
from
70f3ff0 to
8db9848
Compare
Contributor
Author
|
With the release of Tokio 1.47.0 this is now a candidate for merging |
alamb
approved these changes
Jul 27, 2025
Contributor
|
I merged this PR up to resolve a conflict |
Contributor
|
Thanks again @pepijnve |
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
…pache#16748) Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
poll_proceedwhen/if it becomes available in Tokio #16489.Rationale for this change
Using
poll_proceedinstead ofconsume_budgetallows for budget consumption rollback which lets tasks attempt more avenues to make progress.What changes are included in this PR?
coopimplementation to the one based onpoll_proceedAre these changes tested?
Covered by
cooptest cases.Are there any user-facing changes?
Tokio version dependency bump.