Skip to content

Conversation

@gopidesupavan
Copy link
Member

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Change is pin all the github actions, it is more secure way to use github actions and soon ASF infra will enforce to use commit sha for the actions.

More info can be found here, few actions expire soon.
https://github.com/apache/infrastructure-actions/blob/main/actions.yml
https://infra.apache.org/github-actions-policy.html

Are these changes tested?

Are there any user-facing changes?

No

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Jul 29, 2025
@gopidesupavan
Copy link
Member Author

https://octopin.readthedocs.io/en/latest/ very helpful library to pin actions

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gopidesupavan

I double checked all the hash values corresponded to the specified versions

I will sleep better at night with this potential attack vector reduced

@gopidesupavan
Copy link
Member Author

Thank you @gopidesupavan

I double checked all the hash values corresponded to the specified versions

I will sleep better at night with this potential attack vector reduced

cool :) happy to help. and on a side note, it would be nice to have zizmor pre-commit setup https://github.com/zizmorcore/zizmor this is really useful it validates how github action workflows, how tokens usage and syntax etc; very powerful. we at Apache Airflow uses https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml#L366.

If your happy i am fine to add this to datafusion , please let me know :)

@alamb
Copy link
Contributor

alamb commented Jul 30, 2025

Thanks @gopidesupavan 🙏

I am somewhat hesitant to add more CI jobs (that need to be maintained) but I suggest we file a ticket to track the idea of adding zizmor

@alamb alamb merged commit 9b27952 into apache:main Jul 30, 2025
27 checks passed
Standing-Man pushed a commit to Standing-Man/datafusion that referenced this pull request Aug 4, 2025
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@findepi
Copy link
Member

findepi commented Aug 8, 2025

I think it would make sense to add some validation to GH workflows that all 3rd party actions are indeed sha-pinned.
It can be yet another workflow, but it can also be just a Rust test that opens workflow files (yaml) and inspects them. A bit ugly but super powerful.

@gopidesupavan gopidesupavan deleted the pin-github-actions branch August 8, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants