Skip to content

Perf: Port arrow-rs optimization for get_buffer_memory_size and add fast path for no buffer for gc string view #17008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Aug 3, 2025
Merged

Perf: Port arrow-rs optimization for get_buffer_memory_size and add fast path for no buffer for gc string view #17008

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb32e7
Port arrow-rs optimization for get_buffer_memory_size for gc string view
zhuqi-lucas Aug 1, 2025
cddce85
add comments and fast path
zhuqi-lucas Aug 1, 2025
3ecefbf
Merge remote-tracking branch 'upstream/main' into issue_17007
zhuqi-lucas Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion datafusion/physical-plan/src/coalesce/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ fn gc_string_view_batch(batch: &RecordBatch) -> RecordBatch {
let Some(s) = c.as_string_view_opt() else {
return Arc::clone(c);
};

// Fast path: if the data buffers are empty, we can return the original array
if s.data_buffers().is_empty() {
return Arc::clone(c);
}

let ideal_buffer_size: usize = s
.views()
.iter()
Expand All @@ -240,7 +246,11 @@ fn gc_string_view_batch(batch: &RecordBatch) -> RecordBatch {
}
})
.sum();
let actual_buffer_size = s.get_buffer_memory_size();

// We don't use get_buffer_memory_size here, because gc is for the contents of the
// data buffers, not views and nulls.
let actual_buffer_size =
s.data_buffers().iter().map(|b| b.capacity()).sum::<usize>();

// Re-creating the array copies data and can be time consuming.
// We only do it if the array is sparse
Expand Down