Remove redundant plan from extension's check_invariants
#17199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `UserDefinedLogicalNode::check_invariants`, the actual plan to check for invariants is `self`. The `plan` is always `LogicalPlan::Extension` and provides no further information. It's confusing.
github-actions
bot
added
logical-expr
xudong963
approved these changes
Aug 15, 2025
Contributor
|
Update: I was confused |
alamb
approved these changes
Aug 15, 2025
| fn assert_valid_extension_nodes(plan: &LogicalPlan, check: InvariantLevel) -> Result<()> { | ||
| plan.apply_with_subqueries(|plan: &LogicalPlan| { | ||
| if let LogicalPlan::Extension(Extension { node }) = plan { | ||
| node.check_invariants(check, plan)?; |
Contributor
There was a problem hiding this comment.
Oh, I see -- the point is there is no value to getting the plan passed in here as there is nothing else in LogicalPlan::Extension(Extension { node })
That makes sense to me
findepi
deleted the
findepi/remove-redundant-plan-from-extension-s-check-invariants-b53190
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
UserDefinedLogicalNode::check_invariants, the actual plan to check for invariants isself. Theplanis alwaysLogicalPlan::Extensionand provides no further information. It's confusing.