Skip to content

feat: refactor grouping_id #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
chenkovsky wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: refactor grouping_id #17961

chenkovsky wants to merge 11 commits into from

Conversation

@chenkovsky
Copy link
Contributor

@chenkovsky chenkovsky commented Oct 8, 2025

Which issue does this PR close?

Rationale for this change

__grouping_id is internal implementation related. so it should not be exposed in logical plan.

What changes are included in this PR?

in logical level, __grouping_id is hidden now. physical planner will handle this.

Are these changes tested?

UT

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation physical-plan Changes to the physical-plan crate labels Oct 8, 2025
@chenkovsky chenkovsky mentioned this pull request Oct 8, 2025
Closed
@chenkovsky chenkovsky force-pushed the feat/refactor_grouping branch from 4fedfd5 to de35320 Compare October 8, 2025 11:29
@github-actions github-actions bot added the sql SQL Planner label Oct 9, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation substrait Changes to the substrait crate labels Oct 9, 2025
@chenkovsky chenkovsky marked this pull request as ready for review October 9, 2025 00:47
@Blizzara Blizzara mentioned this pull request Oct 13, 2025
Merged
@Jefffrey
Copy link
Contributor

Jefffrey commented Dec 30, 2025

I think this PR would be much easier to review if we had a proper PR body that can help reviewers understand the changes being made; i.e. explain what is being added, summary of changes, justifications, examples, etc.

@Jefffrey Jefffrey marked this pull request as draft December 30, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core Core DataFusion crate documentation Improvements or additions to documentation functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenkovsky @Jefffrey