Fix: Error rather than silently ignore extra parameter passed to ceil/floor#18265
Merged
Jefffrey merged 11 commits intoapache:mainfrom Oct 27, 2025
Merged
Fix: Error rather than silently ignore extra parameter passed to ceil/floor#18265Jefffrey merged 11 commits intoapache:mainfrom
Jefffrey merged 11 commits intoapache:mainfrom
Conversation
Jefffrey
reviewed
Oct 24, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Could we add a test to lock in this behaviour? (Specifically that if we provide scale or datetime then it throws an error)
Preferably as an SLT, see: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
Contributor
Author
|
Thats a good call, I'll get to it |
Contributor
Author
|
I added the two basic tests that throw an error if an extra Scale parameter is passed. Please let me know if there are any imporvements I can make |
Contributor
|
See an example of adding a test that expects to fail: datafusion/datafusion/sqllogictest/test_files/aggregate.slt Lines 203 to 205 in 2a82897
|
Contributor
Author
|
I hope this is alright. |
alamb
approved these changes
Oct 26, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @toxicteddy00077 and @Jefffrey
I also pushed up a test for the to datetime syntax as well
alamb
changed the title
Contributor
|
Thanks @toxicteddy00077 |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…/floor (apache#18265) ## Which issue does this PR close? <!-- --> - Closes apache#18175 ## Rationale for this change <!-- --> The Ceil/Floor calls via SQL was being parsed such that they were taking 2 arguments instead of 1, the second of which is not currently needed and the second argument was being ignored and passed silently. ## What changes are included in this PR? <!-- --> The second parameter(`field`) which was being passed if is of the `CeilFloorKind` enum from `sqlparser` crate . Neither of the enum's two variants (`DateTimeField` and `Scale`)are being implemented hence they have been ignored with apporpriate error type and only succeeds if the `DateTimeField` has `NoDateTime` variant i,e it is treated as empty. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> All Unit Tests pass successfully. --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
…/floor (apache#18265) ## Which issue does this PR close? <!-- --> - Closes apache#18175 ## Rationale for this change <!-- --> The Ceil/Floor calls via SQL was being parsed such that they were taking 2 arguments instead of 1, the second of which is not currently needed and the second argument was being ignored and passed silently. ## What changes are included in this PR? <!-- --> The second parameter(`field`) which was being passed if is of the `CeilFloorKind` enum from `sqlparser` crate . Neither of the enum's two variants (`DateTimeField` and `Scale`)are being implemented hence they have been ignored with apporpriate error type and only succeeds if the `DateTimeField` has `NoDateTime` variant i,e it is treated as empty. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> All Unit Tests pass successfully. --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The Ceil/Floor calls via SQL was being parsed such that they were taking 2 arguments instead of 1, the second of which is not currently needed and the second argument was being ignored and passed silently.
What changes are included in this PR?
The second parameter(
field) which was being passed if is of theCeilFloorKindenum fromsqlparsercrate . Neither of the enum's two variants (DateTimeFieldandScale)are being implemented hence they have been ignored with apporpriate error type and only succeeds if theDateTimeFieldhasNoDateTimevariant i,e it is treated as empty.Are these changes tested?
All Unit Tests pass successfully.