Merged
Conversation
alamb
commented
Dec 1, 2025
| /// True by default. | ||
| /// False by default. | ||
| #[structopt( | ||
| short = "j", |
Contributor
Author
There was a problem hiding this comment.
-j is repeated
Prior to this change, the binary fails like this:
thread 'main' (1416474) panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap-2.34.0/src/app/parser.rs:190:13:
Argument short must be unique
-j is already in use
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Contributor
Author
There was a problem hiding this comment.
The change is to remove the -j short form
alamb
force-pushed
the
alamb/fix_tpch_bench
branch
from
2b7aebc to
eb13f52
Compare
Contributor
|
Allso found it and fixing in #18985 |
Contributor
Author
|
Thanks @comphead for the super fast review Any chance you have a moment for another quick review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
bench.sh run tpchdoesn't work anymore #19032Rationale for this change
See #19032
What changes are included in this PR?
Fix binary
Are these changes tested?
I tested them manually
Are there any user-facing changes?