[Proto]: Serialization support for AsyncFuncExec#19118
Merged
Jefffrey merged 12 commits intoapache:mainfrom Dec 10, 2025
Merged
[Proto]: Serialization support for AsyncFuncExec#19118Jefffrey merged 12 commits intoapache:mainfrom
AsyncFuncExec#19118Jefffrey merged 12 commits intoapache:mainfrom
Conversation
github-actions
bot
added
proto
Jefffrey
reviewed
Dec 7, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Thanks for raising this, left some suggestions for simplifications
Comment on lines
2355
to
2361
| let logical_plan = ctx | ||
| .state() | ||
| .create_logical_plan("select test_async_udf(1)") | ||
| .await?; | ||
| let physical_plan = ctx.state().create_physical_plan(&logical_plan).await?; | ||
| let codec = TestAsyncUDFPhysicalCodec {}; | ||
| roundtrip_test_and_return(physical_plan, &ctx, &codec)?; |
Contributor
There was a problem hiding this comment.
Suggested change
| let logical_plan = ctx | |
| .state() | |
| .create_logical_plan("select test_async_udf(1)") | |
| .await?; | |
| let physical_plan = ctx.state().create_physical_plan(&logical_plan).await?; | |
| let codec = TestAsyncUDFPhysicalCodec {}; | |
| roundtrip_test_and_return(physical_plan, &ctx, &codec)?; | |
| let plan = ctx | |
| .sql("select test_async_udf(1)") | |
| .await? | |
| .create_physical_plan() | |
| .await?; | |
| roundtrip_test_with_context(plan, &ctx)?; |
Simplify the test a little
Contributor
Author
There was a problem hiding this comment.
Sure, but still need the codec.
Contributor
There was a problem hiding this comment.
I tested using roundtrip_test_and_return and it seems to work fine without the codec? Perhaps I'm missing something here?
Contributor
Author
There was a problem hiding this comment.
My mistake -- I was using roundtrip_test without the context (which did not have the UDF registered). Updated 😄!
Jefffrey
reviewed
Dec 7, 2025
Jefffrey
approved these changes
Dec 10, 2025
Contributor
|
Thanks @mach-kernel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #19112
Rationale for this change
Use async functions with Ballista
What changes are included in this PR?
AsyncFuncExecNodeproto definitionAre these changes tested?
n/a
Are there any user-facing changes?
n/a