-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: Add TPCDS benchmarks #19138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add TPCDS benchmarks #19138
Conversation
|
Thanks @Dandandan for the review |
|
I ran this on main after cloning the data from datafusion-benchmarks and a bunch of queries return 0 rows which, without looking at the TPC-DS spec yet, smells wrong to me. Is that expected behavior? |
I have a fix for this in the works |
Which issue does this PR close?
This is PR instead of accidentally rebased #18985
Also
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?