Skip to content

chore(deps): Update sqlparser to 0.60#19672

Merged
Jefffrey merged 11 commits intoapache:mainfrom
Standing-Man:sqlparser-upgrade
Jan 13, 2026
Merged

chore(deps): Update sqlparser to 0.60#19672
Jefffrey merged 11 commits intoapache:mainfrom
Standing-Man:sqlparser-upgrade

Conversation

@Standing-Man
Copy link
Copy Markdown
Contributor

@Standing-Man Standing-Man commented Jan 7, 2026

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Jan 7, 2026
@Standing-Man
Copy link
Copy Markdown
Contributor Author

Standing-Man commented Jan 7, 2026 •
edited
Loading

@Jefffrey and @comphead PTAL when you have time. 😸

@Jefffrey
Copy link
Copy Markdown
Contributor

Jefffrey commented Jan 7, 2026

Could we address the CI failures? Looks like some tests are failing

@Standing-Man
chore(deps): Update sqlparser to 0.60
c2dd55b 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man
fix: fix the table alias and parameter on CreateTable
8b018d8 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man
fix: fix the table constraints parser
563e8da 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man
Copy link
Copy Markdown
Contributor Author

Standing-Man commented Jan 7, 2026

@Jefffrey ready to review.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Jan 7, 2026

I was literally about to sit down and have codex try to do this -- thank you @Standing-Man -- taking a look now

alamb
alamb reviewed Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Standing-Man -- thank you. THe only question I have is about the change of API to use Boxed results

Comment thread datafusion/core/tests/user_defined/user_defined_scalar_functions.rs
Comment thread datafusion/expr/src/planner.rs
Jefffrey
Jefffrey reviewed Jan 8, 2026
View reviewed changes
Comment thread datafusion/expr/src/expr.rs Outdated
Comment thread datafusion/sql/src/values.rs Outdated
Comment thread datafusion/sql/src/query.rs
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
@Standing-Man
chore: add comment for Insert Token
b4a3189 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man Standing-Man requested review from Jefffrey and alamb January 8, 2026 05:54
@Standing-Man
fix: fix the DisPlay for
7f8cf18 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
alamb
alamb reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Standing-Man and @Jefffrey

Comment thread datafusion/sql/src/query.rs
Comment thread datafusion/sql/src/statement.rs Outdated
@Standing-Man
enhance: explicitly destructur tableconstraints
5d0fed6 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Jefffrey
Jefffrey reviewed Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very tempting to not destructure the nested fields/enums because it makes the code less verbose. However, by doing so we miss fields that might be introduced in newer versions. These fields usually correspond to supporting more syntax. If we are unaware of this syntax, it means the SQL dialect we have will start accepting more and more syntax even if we don't do anything with the syntax.

I admit it might be painful and verbose to do it that way but I find its a very good way to use Rust's characteristics to help us catch this issues at compile time, instead of at runtime.

Comment thread datafusion/expr/src/expr.rs Outdated
Comment thread datafusion/sql/src/query.rs
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
Comment thread datafusion/sql/src/statement.rs Outdated
@Jefffrey
Copy link
Copy Markdown
Contributor

Jefffrey commented Jan 9, 2026

@Standing-Man could you please refrain from marking the comments as resolved? I see quite of few of my recent comments were marked as resolved even though no action was taken. Can you leave it to us to determine if a conversation is resolved, it makes it easier for us to review.

@Standing-Man Standing-Man force-pushed the sqlparser-upgrade branch 4 times, most recently from 40f8931 to 4cac0a2 Compare January 9, 2026 05:09
@Standing-Man Standing-Man requested review from Jefffrey and alamb January 9, 2026 06:51
@Standing-Man
enhance: explicitly destructur tableconstraints
8f15b82 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man
chore: fix clippy error
7cf9df4 
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Jefffrey
Jefffrey approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this as API change because RelationPlanning is in the public API

Comment thread datafusion/sql/src/values.rs Outdated
@Jefffrey Jefffrey added the api change Changes the API exposed to users of the crate label Jan 9, 2026
Standing-Man and others added 2 commits January 10, 2026 07:33
@Standing-Man @Jefffrey
Update datafusion/sql/src/values.rs
4acc291 
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
@Standing-Man
Merge branch 'main' into sqlparser-upgrade
68359be
@Standing-Man
Copy link
Copy Markdown
Contributor Author

Standing-Man commented Jan 12, 2026

@alamb, could you take a look when you have time?

@Jefffrey Jefffrey added this pull request to the merge queue Jan 13, 2026
Merged via the queue into apache:main with commit e8efd59 Jan 13, 2026
35 checks passed
@Jefffrey
Copy link
Copy Markdown
Contributor

Jefffrey commented Jan 13, 2026

Thanks @Standing-Man & @alamb

de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
@Standing-Man @alamb
@Jefffrey @de-bgunter
chore(deps): Update sqlparser to 0.60 (apache#19672)
e3736b0 
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes apache#19671.

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

---------

Signed-off-by: StandingMan <jmtangcs@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

@alamb alamb Awaiting requested review from alamb

Assignees

No one assigned

Labels

api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bump sqlparser from 0.59.0 to 0.60.0

3 participants

@Standing-Man @Jefffrey @alamb