Ensure null inputs to array setop functions return null output#19683
Merged
alamb merged 4 commits intoapache:mainfrom Jan 16, 2026
Merged
Ensure null inputs to array setop functions return null output#19683alamb merged 4 commits intoapache:mainfrom
alamb merged 4 commits intoapache:mainfrom
Conversation
Jefffrey
commented
Jan 7, 2026
Comment on lines
-371
to
+372
| let l_values = if let Some(first_arr) = first_arr { | ||
| converter.convert_columns(&[first_arr])? | ||
| } else { | ||
| ele_should_be_null = true; | ||
| converter.empty_rows(0, 0) | ||
| }; | ||
|
|
||
| let r_values = if let Some(second_arr) = second_arr { | ||
| converter.convert_columns(&[second_arr])? | ||
| } else { | ||
| ele_should_be_null = true; | ||
| converter.empty_rows(0, 0) | ||
| let (l_values, r_values) = match (l_arr, r_arr) { | ||
| (Some(l_arr), Some(r_arr)) => ( | ||
| converter.convert_columns(&[l_arr])?, | ||
| converter.convert_columns(&[r_arr])?, | ||
| ), | ||
| _ => { |
Contributor
Author
There was a problem hiding this comment.
Little drive-by refactor here to skip the set logic below for nulls
github-actions
Bot
added
the
documentation
kosiew
approved these changes
Jan 14, 2026
| continue; | ||
| } | ||
|
|
||
| for i in r_start.as_usize()..r_end.as_usize() { |
Contributor
There was a problem hiding this comment.
Did you intentionally want to shadow i which is used in the outer for loop?
Contributor
Author
There was a problem hiding this comment.
This wasn't intentional, refactored the names to clear things up 👍
Contributor
|
woohoo -- let's keep the code flowing |
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…e#19683) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#19682 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Explained in issue. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Change array_except, array_intersect and array_union UDFs to return null if either input is null. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Added & fixed tests. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Behaviour change to a function output. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Explained in issue.
What changes are included in this PR?
Change array_except, array_intersect and array_union UDFs to return null if either input is null.
Are these changes tested?
Added & fixed tests.
Are there any user-facing changes?
Behaviour change to a function output.