Skip to content

chore: bump dependabot PR limit for cargo from 5 to 15#19730

Merged
Jefffrey merged 1 commit intoapache:mainfrom
Jefffrey:bump-dependabot-limit
Jan 11, 2026
Merged

chore: bump dependabot PR limit for cargo from 5 to 15#19730
Jefffrey merged 1 commit intoapache:mainfrom
Jefffrey:bump-dependabot-limit

Conversation

@Jefffrey
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey commented Jan 10, 2026

Which issue does this PR close?

  • N/A

Rationale for this change

Occasionally we do PRs to bump a bunch of versions in Cargo.lock, recent example:

Ideally this should be handled by dependabot already. I suspect the default limit of 5 is preventing dependabot from creating all the PRs it needs; this causes it to error and those version bumps are "lost".

  • I say "lost" but dependabot can pick it up on the next run... if it doesn't error again

See an example from a dependabot run:

image

From the logs:

 +-------------------------------------------------------+
|          Changes to Dependabot Pull Requests          |
+---------+---------------------------------------------+
| created | insta ( from 1.45.0 to 1.46.0 )             |
| created | tracing ( from 0.1.43 to 0.1.44 )           |
| created | syn ( from 2.0.111 to 2.0.113 )             |
| created | async-compression ( from 0.4.35 to 0.4.36 ) |
| created | object_store ( from 0.12.4 to 0.13.0 )      |
| created | serde_json ( from 1.0.145 to 1.0.148 )      |
| created | bigdecimal ( from 0.4.9 to 0.4.10 )         |
| created | clap ( from 4.5.53 to 4.5.54 )              |
| created | libc ( from 0.2.177 to 0.2.179 )            |
| created | tokio ( from 1.48.0 to 1.49.0 )             |
| created | tokio-util ( from 0.7.17 to 0.7.18 )        |
| created | sqllogictest ( from 0.28.4 to 0.29.0 )      |
+---------+---------------------------------------------+

We expect to have all these PRs created (this was for the run 5 days ago), but only these were created on that day:

And considering these PRs were still open at the time:

We can see it hit the 5 limit.

Dependabot default behavior:

  • If five pull requests with version updates are open, no further pull requests are raised until some of those open requests are merged or closed.
  • Security updates have a separate, internal limit of ten open pull requests which cannot be changed.

What changes are included in this PR?

Bump the limit to 15. We might have an appetite for increasing it more, 15 was chosen arbitrarily.

Are these changes tested?

Dependabot only.

Are there any user-facing changes?

No.

@Jefffrey Jefffrey added the development-process Related to development process of DataFusion label Jan 10, 2026
@Jefffrey Jefffrey mentioned this pull request Jan 10, 2026
@Jefffrey
Copy link
Copy Markdown
Contributor Author

(note to self)

Saw these too in log:

 Dependabot encountered '2' error(s) during execution, please check the logs for more details.
+---------------------------------------------+
|        Dependencies failed to update        |
+-------------+---------------+---------------+
| Dependency  | Error Type    | Error Details |
+-------------+---------------+---------------+
| parking_lot | unknown_error | null          |
| tempfile    | unknown_error | null          |
+-------------+---------------+---------------+

Look into this

Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jefffrey

I would also check https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#groups-- to group minor updates into a single PR, excluding major things, like parser, arrow, object_store, parquet

I create a followup on this to prevent creating too many PRs.

@Jefffrey
Copy link
Copy Markdown
Contributor Author

Thanks @comphead

I'll merge this in so it takes effect in the next weekly run tomorrow

I would also check https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#groups-- to group minor updates into a single PR, excluding major things, like parser, arrow, object_store, parquet

I create a followup on this to prevent creating too many PRs.

This sounds good as a followup 👍

@Jefffrey Jefffrey added this pull request to the merge queue Jan 11, 2026
Merged via the queue into apache:main with commit 30c6ff1 Jan 11, 2026
30 checks passed
@Jefffrey Jefffrey deleted the bump-dependabot-limit branch January 11, 2026 11:16
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Jan 12, 2026

Thank you @Jefffrey

@comphead
Copy link
Copy Markdown
Contributor

This sounds good as a followup 👍

PR #20457

de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- N/A

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

Occasionally we do PRs to bump a bunch of versions in `Cargo.lock`,
recent example:

- apache#19667

Ideally this should be handled by dependabot already. I suspect the
default limit of 5 is preventing dependabot from creating all the PRs it
needs; this causes it to error and those version bumps are "lost".

- I say "lost" but dependabot can pick it up on the next run... if it
doesn't error again

See an example from a dependabot run:

<img width="703" height="118" alt="image"
src="https://github.com/user-attachments/assets/f8ae6b70-6fe1-4613-8c60-28564c23188b"
/>

From the logs:

```text
 +-------------------------------------------------------+
|          Changes to Dependabot Pull Requests          |
+---------+---------------------------------------------+
| created | insta ( from 1.45.0 to 1.46.0 )             |
| created | tracing ( from 0.1.43 to 0.1.44 )           |
| created | syn ( from 2.0.111 to 2.0.113 )             |
| created | async-compression ( from 0.4.35 to 0.4.36 ) |
| created | object_store ( from 0.12.4 to 0.13.0 )      |
| created | serde_json ( from 1.0.145 to 1.0.148 )      |
| created | bigdecimal ( from 0.4.9 to 0.4.10 )         |
| created | clap ( from 4.5.53 to 4.5.54 )              |
| created | libc ( from 0.2.177 to 0.2.179 )            |
| created | tokio ( from 1.48.0 to 1.49.0 )             |
| created | tokio-util ( from 0.7.17 to 0.7.18 )        |
| created | sqllogictest ( from 0.28.4 to 0.29.0 )      |
+---------+---------------------------------------------+
```

We expect to have all these PRs created (this was for the run 5 days
ago), but only these were created on that day:

- apache#19645
- apache#19644
- apache#19643

And considering these PRs were still open at the time:

- apache#19544
- apache#19325

We can see it hit the 5 limit.

> Dependabot default behavior:
>
> - If five pull requests with version updates are open, no further pull
requests are raised until some of those open requests are merged or
closed.
> - Security updates have a separate, internal limit of ten open pull
requests which cannot be changed.

-
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#open-pull-requests-limit-

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

Bump the limit to 15. We might have an appetite for increasing it more,
15 was chosen arbitrarily.

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Dependabot only.

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

No.

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants