perf: Optimize floor and ceil scalar performance#19752
Merged
comphead merged 3 commits intoapache:mainfrom Jan 12, 2026
Merged
Conversation
Jefffrey
reviewed
Jan 11, 2026
| ScalarValue::Null => { | ||
| return Ok(ColumnarValue::Scalar(ScalarValue::Float64(None))); | ||
| } | ||
| // Decimal types fall through to array path for overflow validation |
Contributor
There was a problem hiding this comment.
For decimals, we could turn the scalars in arrays of size 1, pass through the existing code, then recreate a scalar from the resultant array, to benefit from code reuse and ensure we don't expand the array.
Not the cleanest way to do it but certainly the easiest.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback.
Jefffrey
approved these changes
Jan 12, 2026
Dandandan
added a commit
to Dandandan/arrow-datafusion
that referenced
this pull request
Jan 12, 2026
This reverts commit d484c09.
Dandandan
added a commit
to Dandandan/arrow-datafusion
that referenced
this pull request
Jan 12, 2026
…che#19752)"" This reverts commit 58090ab.
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Part of apache/datafusion-comet#2986 ## Rationale for this change - The current floor and ceil implementations always convert scalar inputs to arrays via `values_to_arrays()`, which introduces unnecessary overhead when processing single values. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? - Add scalar fast path for floor and ceil - Add criterion benchmark for floor/ceil to measure performance <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? - All sqllogictest pass - Addec benchmark | Benchmark | Array Time | Scalar Time | Speedup | |---------------------|------------|-------------|---------| | floor_f64 (1024) | ~396 ns | ~147 ns | 2.7× | | ceil_f64 (1024) | ~363 ns | ~150 ns | 2.4× | | floor_f64 (4096) | ~681 ns | ~144 ns | 4.7× | | ceil_f64 (4096) | ~667 ns | ~144 ns | 4.6× | | floor_f64 (8192) | ~1,638 ns | ~144 ns | 11.4× | | ceil_f64 (8192) | ~1,634 ns | ~144 ns | 11.3× | <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? No <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
values_to_arrays(), which introduces unnecessary overhead when processing single values.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No