perf: Optimize factorial scalar path#19949
Merged
Jefffrey merged 2 commits intoapache:mainfrom Jan 24, 2026
Merged
Conversation
Jefffrey
approved these changes
Jan 23, 2026
| 6402373705728000, | ||
| 121645100408832000, | ||
| 2432902008176640000, | ||
| ]; // if return type changes, this constant needs to be updated accordingly |
Contributor
There was a problem hiding this comment.
Would be good to keep this comment
Contributor
|
Thanks @kumarUjjawal |
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Part of apache/datafusion-comet#2986. ## Rationale for this change The `factorial` function currently converts scalar inputs to arrays before processing. Adding a scalar fast path avoids this overhead and improves performance. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? 1. Refactored `invoke_with_args` to use `match` statement for handling both scalar and array inputs 2. Inlined array processing logic, removing `make_scalar_function` usage. | Type | Before | After | Speedup | |------|--------|-------|---------| | **factorial_scalar** | 244 ns | 102 ns | **2.4x** | <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes, covered by existing SLT tests: - `scalar.slt` lines 461-477 - `math.slt` line 797 <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
factorialfunction currently converts scalar inputs to arrays before processing. Adding a scalar fast path avoids this overhead and improves performance.What changes are included in this PR?
invoke_with_argsto usematchstatement for handling both scalar and array inputsmake_scalar_functionusage.Are these changes tested?
Yes, covered by existing SLT tests:
scalar.sltlines 461-477math.sltline 797Are there any user-facing changes?