Skip to content

perf: Optimize scalar path for ascii function#19951

Merged
Dandandan merged 1 commit intoapache:mainfrom
kumarUjjawal:perf/ascii_scalar_path
Jan 24, 2026
Merged

perf: Optimize scalar path for ascii function#19951
Dandandan merged 1 commit intoapache:mainfrom
kumarUjjawal:perf/ascii_scalar_path

Conversation

@kumarUjjawal
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

The ascii function currently converts scalar inputs to arrays before processing via make_scalar_function. Adding a scalar fast path avoids this overhead and improves performance.

What changes are included in this PR?

  1. Refactored invoke_with_args to use match statement for handling both scalar and array inputs
  2. Added scalar fast path for Utf8, LargeUtf8, and Utf8View scalar inputs
Type Before After Speedup
ascii/scalar_utf8 234 ns 56 ns 4.2x
ascii/scalar_utf8view 206 ns 57 ns 3.6x

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions Bot added the functions Changes to functions implementation label Jan 23, 2026
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @kumarUjjawal

BTW if you wanted to optimize this more another thing you can do is to make two different loops -- when there is null and when there are no nulls, rather than checking on each iteration here

fn calculate_ascii<'a, V>(array: &V) -> Result<ArrayRef, ArrowError>
where
V: StringArrayType<'a, Item = &'a str>,
{
let values: Vec<_> = (0..array.len())
.map(|i| {
if array.is_null(i) {
0
} else {
let s = array.value(i);
s.chars().next().map_or(0, |c| c as i32)
}
})
.collect();
let array = Int32Array::new(values.into(), array.nulls().cloned());
Ok(Arc::new(array))
}

@Dandandan Dandandan added this pull request to the merge queue Jan 24, 2026
Merged via the queue into apache:main with commit c5e99e5 Jan 24, 2026
28 checks passed
de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Part of apache/datafusion-comet#2986.

## Rationale for this change


The `ascii` function currently converts scalar inputs to arrays before
processing via `make_scalar_function`. Adding a scalar fast path avoids
this overhead and improves performance.

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

1. Refactored `invoke_with_args` to use `match` statement for handling
both scalar and array inputs
2. Added scalar fast path for `Utf8`, `LargeUtf8`, and `Utf8View` scalar
inputs

| Type | Before | After | Speedup |
|------|--------|-------|---------|
| **ascii/scalar_utf8** | 234 ns | 56 ns | **4.2x** |
| **ascii/scalar_utf8view** | 206 ns | 57 ns | **3.6x** |

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

Yes

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

No

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants