Fix stuck issue for the load testing of Push-based task scheduling #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2022 13:53
…ServerEvent::JobSubmitted in offer_resources()
liukun4515
reviewed
Mar 16, 2022
| return Ok(Some(SchedulerServerEvent::JobSubmitted(job_id))); | ||
| } | ||
|
|
||
| let mut executors_delta_data: Vec<ExecutorDeltaData> = available_executors |
Contributor
There was a problem hiding this comment.
executors_delta_data is confused for me, because this just clone/copy some attributes from available_executors
Member
There was a problem hiding this comment.
ResourceChange or SlotsChange probably?
liukun4515
approved these changes
Mar 16, 2022
Contributor
liukun4515
left a comment
liukun4515
left a comment
There was a problem hiding this comment.
LTGM
except for some naming
Member
|
Thanks @yahoNanJing @liukun4515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2005 .
Rationale for this change
What changes are included in this PR?
For the first bug:
We should make sure the returned available_executors should be all with available_task_slots > 0.
For the second bug:
We should use update_executor_data rather than save_executor_data to update executors' available_task_slots.
Are there any user-facing changes?