Add StructArray and RunArray benchmark tests to with_hashes#20182
Merged
adriangb merged 6 commits intoapache:mainfrom Feb 11, 2026
Merged
Add StructArray and RunArray benchmark tests to with_hashes#20182adriangb merged 6 commits intoapache:mainfrom
StructArray and RunArray benchmark tests to with_hashes#20182adriangb merged 6 commits intoapache:mainfrom
Conversation
Jefffrey
reviewed
Feb 7, 2026
Jefffrey
reviewed
Feb 8, 2026
| do_hash_test(b, &arrays); | ||
| }); | ||
|
|
||
| // Union arrays can't have null bitmasks |
Contributor
There was a problem hiding this comment.
Mentioning union array when we don't implement that here?
Contributor
Author
There was a problem hiding this comment.
I've copied that from the other PR verbatim 😅 (to not have merge conflicts in the future?). but I'm getting a sense that it's the wrong approach here!
| .clone() | ||
| .into_data() | ||
| .into_builder() | ||
| .nulls(Some(create_null_mask(values.len()))) |
Contributor
There was a problem hiding this comment.
Something to think about is how null density acts differently here for run arrays, since we'd apply null on entire runs 🤔
Contributor
Author
There was a problem hiding this comment.
I was thinking about it for a while. It probably should come up to be around the same 3% zone even though the variance could be a bit high.
I've set the run_length to be within 1..50.
Let's say we have ~300 runs on average, with each each one carrying ~25 elements. 3% of which will roughly translate to 10 * 25 = 250. But yes that is probably our ideal scenario.
let me know what you think? i'll try to do some testing regarding this.
| ) | ||
| } | ||
|
|
||
| fn string_array(array_len: usize) -> ArrayRef { |
Contributor
There was a problem hiding this comment.
Do we need this if we already have StringPool above?
Contributor
Author
There was a problem hiding this comment.
done! don't think a different one offers any benefit! both seem to give me close to 10% speed up locally (with the struct_array optimization)
Jefffrey
approved these changes
Feb 9, 2026
Contributor
|
run benchmark with_hashes |
|
🤖 |
|
🤖: Benchmark completed Details
|
de-bgunter
pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…ache#20182) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#20181 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Issue apache#20152 shows some areas of optimization for `RunArray` and `StructArray` hashing. But the existing `with_hashes` benchmark tests don't include coverage for these! ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Added benchmarks to `with_hashes.rs`: - **StructArray**: 4-column struct (bool, int32, int64, string) - **RunArray**: Int32 run-encoded array - Both include single/multiple columns and with/without nulls ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> No additional tests added, but the benchmarks both compile and run. <details> <summary>a sample run:</summary> ``` ❯ cargo bench --features=parquet --bench with_hashes -- array Compiling datafusion-common v52.1.0 (/Users/notashes/dev/datafusion/datafusion/common) Finished `bench` profile [optimized] target(s) in 34.49s Running benches/with_hashes.rs (target/release/deps/with_hashes-2f180744d22084f3) Gnuplot not found, using plotters backend struct_array: single, no nulls time: [38.389 µs 38.437 µs 38.485 µs] Found 5 outliers among 100 measurements (5.00%) 1 (1.00%) low severe 2 (2.00%) low mild 2 (2.00%) high mild struct_array: single, nulls time: [46.108 µs 46.197 µs 46.291 µs] Found 4 outliers among 100 measurements (4.00%) 3 (3.00%) high mild 1 (1.00%) high severe struct_array: multiple, no nulls time: [114.64 µs 114.79 µs 114.93 µs] Found 4 outliers among 100 measurements (4.00%) 1 (1.00%) low severe 2 (2.00%) low mild 1 (1.00%) high mild struct_array: multiple, nulls time: [138.29 µs 138.62 µs 139.07 µs] Found 8 outliers among 100 measurements (8.00%) 1 (1.00%) low severe 4 (4.00%) low mild 1 (1.00%) high mild 2 (2.00%) high severe run_array_int32: single, no nulls time: [1.8777 µs 1.9098 µs 1.9457 µs] Found 3 outliers among 100 measurements (3.00%) 3 (3.00%) high mild run_array_int32: single, nulls time: [2.0110 µs 2.0417 µs 2.0751 µs] Found 7 outliers among 100 measurements (7.00%) 6 (6.00%) high mild 1 (1.00%) high severe run_array_int32: multiple, no nulls time: [5.0511 µs 5.0603 µs 5.0693 µs] Found 6 outliers among 100 measurements (6.00%) 1 (1.00%) low mild 5 (5.00%) high mild run_array_int32: multiple, nulls time: [5.6052 µs 5.6201 µs 5.6353 µs] Found 4 outliers among 100 measurements (4.00%) 3 (3.00%) high mild 1 (1.00%) high severe ``` </details> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
StructArrayandRunArraybenchmarks towith_hashessuite in datafusion-common #20181Rationale for this change
Issue #20152 shows some areas of optimization for
RunArrayandStructArrayhashing. But the existingwith_hashesbenchmark tests don't include coverage for these!What changes are included in this PR?
Added benchmarks to
with_hashes.rs:Are these changes tested?
No additional tests added, but the benchmarks both compile and run.
a sample run:
Are there any user-facing changes?