Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 8, 2026

Which issue does this PR close?

Rationale for this change

While reviewing the change with Codex, I noticed that the actual output names and their uniqueness were not verified, which I think would help the coverage

What changes are included in this PR?

Extend the test

Are these changes tested?

Yes it is only tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the substrait Changes to the substrait crate label Feb 8, 2026
Copy link
Contributor

@nuno-faria nuno-faria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xanderbailey xanderbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor Author

alamb commented Feb 9, 2026

Thank you @nuno-faria and @xanderbailey

@alamb alamb added this pull request to the merge queue Feb 9, 2026
Merged via the queue into apache:main with commit 7788c73 Feb 9, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants