Draft
Conversation
blaginin
commented
Feb 10, 2026
.github/workflows/rust.yml
Outdated
| linux-build-lib: | ||
| name: linux build test | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} |
Collaborator
Author
There was a problem hiding this comment.
this one is quite lightweight, i switched to just 8 cpu and got the same ish time
alamb
reviewed
Feb 12, 2026
| linux-build-lib: | ||
| name: linux build test | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m7a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} | ||
| runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} |
Contributor
There was a problem hiding this comment.
One thing I was thinking is that someone in the future may run into this and have a hard time understanding what all the runs-on is all about
I didn't see it documented anywhere -- https://github.com/search?q=repo%3Aapache%2Fdatafusion%20runs-on&type=code
Is there any chance that you could write up some documentation in a README that explains why we are using runs-on and how to apply/unapply it?
For example, it might not be obvious without the context of this PR, to know that
runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}Was the same as
runs-on: ubuntu-latestExcept that in the apache repo it triggers the use of special runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #20107: switch more actions to the new flow