Skip to content

Runs-on for extended CI checks#20511

Merged
blaginin merged 10 commits intomainfrom
db/extended-runs-on
Feb 24, 2026
Merged

Runs-on for extended CI checks#20511
blaginin merged 10 commits intomainfrom
db/extended-runs-on

Conversation

@blaginin
Copy link
Member

@blaginin blaginin commented Feb 23, 2026

part of #20052

Which issue does this PR close?

example run: https://github.com/apache/datafusion/actions/runs/22325922758

this recused the run time from 3h to 1h. still a lot (on my mac it runs in 5m!) but that's a start

@blaginin blaginin self-assigned this Feb 23, 2026
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Feb 23, 2026
blaginin and others added 2 commits February 23, 2026 21:38
Print test thread count and available parallelism at startup to help
debug CI performance issues. Also add periodic progress output for
CI environments (no TTY) to show test completion status.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 23, 2026
blaginin and others added 4 commits February 23, 2026 21:51
Add timing information to identify which test files are taking the
longest to complete, helping diagnose CI performance bottlenecks.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Switch from m8a.12xlarge (48 AMD cores) to c7i.4xlarge (16 Intel cores)
for better single-thread performance. The sqlite tests are bottlenecked
by large files running sequentially, so faster cores matter more than
core count.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@blaginin blaginin marked this pull request as ready for review February 23, 2026 23:08
let completed_count = Arc::clone(&completed_count);
move |_| {
let completed = completed_count.fetch_add(1, Ordering::Relaxed) + 1;
// In CI (no TTY), print progress every 10% or every 50 files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// In CI (no TTY), print progress every 10% or every 50 files
// In CI (no TTY), print progress after every 50 files and at the end

there is no logic for every 10%

@kosiew
Copy link
Contributor

kosiew commented Feb 24, 2026

@blaginin blaginin added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 11ef486 Feb 24, 2026
55 checks passed
@alamb alamb deleted the db/extended-runs-on branch March 17, 2026 18:09
de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
part of apache#20052

## Which issue does this PR close?


example run:
https://github.com/apache/datafusion/actions/runs/22325922758

this recused the run time from 3h to 1h. still a lot (on my mac it runs
in 5m!) but that's a start

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants