Skip to content

Conversation

@jackwener
Copy link
Member

Which issue does this PR close?

Closes #2086.

What changes are included in this PR?

Are there any user-facing changes?

@jackwener
Copy link
Member Author

It's from CI of node

@jackwener
Copy link
Member Author

We can see the result of those change in this PR.

@yjshen
Copy link
Member

yjshen commented Mar 25, 2022

I suppose draft is a way to tag PRs that are not ready for review? Are we experiencing insufficient resources or similar problems currently?

@jackwener
Copy link
Member Author

I suppose draft is a way to tag PRs that are not ready for review? Are we experiencing insufficient resources or similar problems currently?

Yes, I'm write a draft PR #2084. It's just want to ask for help, I don't want to trigger CI.
So is #2054.

@matthewmturner
Copy link
Contributor

In my case I find value in seeing CI run even when in draft state. I would think it's ok to keep as long as it isn't draining some limited resource (I'm unsure how that works with Apache projects).

@jackwener
Copy link
Member Author

In my case I find value in seeing CI run even when in draft state. I would think it's ok to keep as long as it isn't draining some limited resource (I'm unsure how that works with Apache projects).

This can save CI resource, I think it's valuable. Because run CI for not ready PR is not meaningful.

@jackwener jackwener marked this pull request as ready for review March 27, 2022 09:26
@jychen7
Copy link
Contributor

jychen7 commented Mar 27, 2022

In my case I find value in seeing CI run even when in draft state

I also agree on that. Because running full test case locally is time consuming. In my case, I always run related test cases locally for my change and if it looks good, draft a PR to trigger a full run. If all checks have passed in Draft, then convert to "Ready for review"

@jackwener jackwener closed this Mar 30, 2022
@jackwener jackwener deleted the draft branch November 16, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Disable Github CI for draft PRs with label

4 participants