Skip to content

Reduce parquet struct projection benchmark data volume #21187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriangb merged 3 commits into from
Mar 27, 2026
Merged

Reduce parquet struct projection benchmark data volume #21187

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4f18f
tune benchmark
friendlymatthew Mar 26, 2026
d2c8373
make even faster
adriangb Mar 27, 2026
ec8311c
Revert OnceLock caching and add warm_up_time(1s) to benchmarks
adriangb Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions datafusion/core/benches/parquet_struct_projection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,15 @@ use parquet::file::properties::{WriterProperties, WriterVersion};
use std::hint::black_box;
use std::path::Path;
use std::sync::Arc;
use std::time::Duration;
use tempfile::NamedTempFile;
use tokio::runtime::Runtime;

const NUM_BATCHES: usize = 64;
const WRITE_RECORD_BATCH_SIZE: usize = 4096;
const ROW_GROUP_ROW_COUNT: usize = 65536;
const EXPECTED_ROW_GROUPS: usize = 4;
const LARGE_STRING_LEN: usize = 128 * 1024;
const NUM_BATCHES: usize = 2;
const WRITE_RECORD_BATCH_SIZE: usize = 256;
const ROW_GROUP_ROW_COUNT: usize = 256;
const EXPECTED_ROW_GROUPS: usize = 2;
const LARGE_STRING_LEN: usize = 16 * 1024;

fn narrow_schema() -> SchemaRef {
let struct_fields = Fields::from(vec![
Expand Down Expand Up @@ -209,6 +210,9 @@ fn narrow_benchmarks(c: &mut Criterion) {
let ctx = create_context(&rt, &file_path, "t");

let mut group = c.benchmark_group("narrow_struct");
group.sample_size(10);
group.warm_up_time(Duration::from_secs(1));
group.measurement_time(Duration::from_secs(2));

// baseline: full struct, must decode both leaves
group.bench_function("select_struct", |b| {
Expand Down Expand Up @@ -253,6 +257,9 @@ fn wide_benchmarks(c: &mut Criterion) {
let ctx = create_context(&rt, &file_path, "t");

let mut group = c.benchmark_group("wide_struct");
group.sample_size(10);
group.warm_up_time(Duration::from_secs(1));
group.measurement_time(Duration::from_secs(2));

// baseline: full struct, must decode all 5 leaves
group.bench_function("select_struct", |b| {
Expand Down Expand Up @@ -359,6 +366,9 @@ fn nested_benchmarks(c: &mut Criterion) {
let ctx = create_context(&rt, &file_path, "t");

let mut group = c.benchmark_group("nested_struct");
group.sample_size(10);
group.warm_up_time(Duration::from_secs(1));
group.measurement_time(Duration::from_secs(2));

// baseline: full outer struct, decode all 3 leaves
group.bench_function("select_struct", |b| {
Expand Down
Loading