Skip to content

Update 53 upgrade guide to note release, other changes#21449

Merged
alamb merged 4 commits intoapache:mainfrom
alamb:alamb/update_upgrade_guide
Apr 9, 2026
Merged

Update 53 upgrade guide to note release, other changes#21449
alamb merged 4 commits intoapache:mainfrom
alamb:alamb/update_upgrade_guide

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Apr 7, 2026

Which issue does this PR close?

Rationale for this change

@rluvaton noted some issues with the 53 upgrade guide #19692 (comment):

FYI, the migration guide says 53.0.0 was not released yet and it miss the following breaking changes:

#20319 - removed deprecated function from ExecutionPlan trait
#19635 - added argument to HashJoinExec::try_new function

What changes are included in this PR?

Fix the above

Are these changes tested?

Yes by CI

Are there any user-facing changes?

Better docs

@alamb alamb changed the title Update 53 upgrade guide to note release Update 53 upgrade guide to note release, other changes Apr 7, 2026
@alamb alamb marked this pull request as ready for review April 8, 2026 11:30
@alamb alamb requested a review from rluvaton April 8, 2026 11:31
@alamb alamb added the documentation Improvements or additions to documentation label Apr 8, 2026
Copy link
Copy Markdown
Member

@rluvaton rluvaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +154 to +162
### `HashJoinExec::try_new` adds `null_aware`

`HashJoinExec::try_new` now takes an extra `null_aware: bool` argument. This
flag is used for null-aware anti joins, such as plans generated for `NOT IN`
subqueries.

Most callers should pass `false`. Pass `true` only for null-aware
`JoinType::LeftAnti` joins. DataFusion validates that null-aware joins are
single-column `LeftAnti` joins.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention what was the prev behavior?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 20be4a6

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Apr 9, 2026

Thank you for the review @rluvaton

@alamb alamb added this pull request to the merge queue Apr 9, 2026
Merged via the queue into apache:main with commit 8d91fb0 Apr 9, 2026
9 checks passed
@alamb alamb deleted the alamb/update_upgrade_guide branch April 9, 2026 18:39
Rich-T-kid pushed a commit to Rich-T-kid/datafusion that referenced this pull request Apr 21, 2026
## Which issue does this PR close?

- Related to apache#19692

## Rationale for this change

@rluvaton noted some issues with the 53 upgrade guide
apache#19692 (comment):

> FYI, the migration guide says 53.0.0 was not released yet and it miss
the following breaking changes:
> 
> apache#20319 - removed deprecated
function from ExecutionPlan trait
> apache#19635 - added argument to
HashJoinExec::try_new function

## What changes are included in this PR?

Fix the above

## Are these changes tested?
Yes by CI

## Are there any user-facing changes?

Better docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants