Skip to content

feat: support array_compact builtin function#21522

Merged
mbutrovich merged 5 commits intoapache:mainfrom
comphead:array_compact
Apr 15, 2026
Merged

feat: support array_compact builtin function#21522
mbutrovich merged 5 commits intoapache:mainfrom
comphead:array_compact

Conversation

@comphead
Copy link
Copy Markdown
Contributor

@comphead comphead commented Apr 9, 2026 •
edited
Loading

Which issue does this PR close?

  • Closes #.

Rationale for this change

Create array_compact function which removes NULLs from input array. There is no direct counterparty in DuckDB however the function used in Spark, SnowFlake

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Apr 9, 2026
@comphead comphead mentioned this pull request Apr 9, 2026
Open
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 9, 2026
Jefffrey
Jefffrey reviewed Apr 10, 2026
View reviewed changes
Comment thread datafusion/functions-nested/src/array_compact.rs Outdated
}

/// array_compact SQL function
pub fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
fn array_compact_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {

Comment thread datafusion/functions-nested/src/array_compact.rs Outdated
false,
Capacities::Array(original_data.len()),
);
let mut valid = NullBufferBuilder::new(list_array.len());
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can directly grab null buffer from input array for the output array to avoid needing a builder here

Comment thread datafusion/sqllogictest/test_files/array.slt
[[1, 2], [3, 4], [5, 6], [7, 8], [9, 10]]
[[5, 6], NULL]

## array_compact (aliases: `list_compact`)
Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a test for fixedsizelist?

@comphead
Copy link
Copy Markdown
Contributor Author

comphead commented Apr 10, 2026

Thanks @Jefffrey addressed the comments.

One thing comes to my mind is: arrays.slt becomes unmanageable, we need to split it up into smaller files, file per function basis

@comphead comphead requested a review from Jefffrey April 11, 2026 19:00
@comphead comphead mentioned this pull request Apr 11, 2026
Open
mbutrovich
mbutrovich reviewed Apr 13, 2026
View reviewed changes
Comment thread datafusion/functions-nested/src/array_compact.rs
Capacities::Array(capacity),
);

for row_index in 0..list_array.len() {
Copy link
Copy Markdown
Contributor

@mbutrovich mbutrovich Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

let nulls = list_array.nulls();
for row_index in 0..list_array.len() {
  if nulls.is_some_and(|n| n.is_null(row_index)) {
    offsets.push(offsets[row_index]);
    continue;
  }

would make it consistent with behavior in #21482 and #21532

@mbutrovich mbutrovich added this pull request to the merge queue Apr 15, 2026
@mbutrovich
Copy link
Copy Markdown
Contributor

mbutrovich commented Apr 15, 2026

Thanks @comphead!

Merged via the queue into apache:main with commit 26c6121 Apr 15, 2026
32 checks passed
@comphead comphead mentioned this pull request Apr 15, 2026
Closed
Rich-T-kid pushed a commit to Rich-T-kid/datafusion that referenced this pull request Apr 21, 2026
@comphead @Rich-T-kid
feat: support array_compact builtin function (apache#21522)
830f96f 
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes #.

## Rationale for this change

Create `array_compact` function which removes NULLs from input array.
There is no direct counterparty in DuckDB however the function used in
Spark, SnowFlake

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
This was referenced Apr 21, 2026
Merged
Merged
gabotechs pushed a commit to DataDog/datafusion that referenced this pull request Apr 22, 2026
@comphead @gabotechs
feat: support array_compact builtin function (apache#21522)
6c29a5a 
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes #.

## Rationale for this change

Create `array_compact` function which removes NULLs from input array.
There is no direct counterparty in DuckDB however the function used in
Spark, SnowFlake

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

(cherry picked from commit 26c6121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbutrovich mbutrovich mbutrovich left review comments

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comphead @mbutrovich @Jefffrey