Fix HashJoin evaluating during plan #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 22, 2022
| num_rows, | ||
| start.elapsed().as_millis() | ||
| ); | ||
| let on_right = self.on.iter().map(|on| on.1.clone()).collect::<Vec<_>>(); |
Contributor
Author
There was a problem hiding this comment.
I recommend comparing with whitespace ignored - https://github.com/apache/arrow-datafusion/pull/2317/files?w=1
tustvold
commented
Apr 22, 2022
| let right_stream = self.right.execute(partition, context.clone()).await?; | ||
| let on_right = self.on.iter().map(|on| on.1.clone()).collect::<Vec<_>>(); | ||
|
|
||
| let num_rows = left_data.1.num_rows(); |
Contributor
Author
There was a problem hiding this comment.
This logic is moved into the stream implementation
tustvold
commented
Apr 22, 2022
| match build_side.as_ref() { | ||
| Some(stream) => stream.clone(), | ||
| None => { | ||
| let start = Instant::now(); |
Contributor
Author
There was a problem hiding this comment.
This logic is moved into collect_left_input
alamb
approved these changes
Apr 26, 2022
| RecordBatchStream, SendableRecordBatchStream, | ||
| }; | ||
| use crate::execution::context::TaskContext; | ||
| use crate::physical_plan::join_utils::{OnceAsync, OnceFut}; |
Dandandan
approved these changes
Apr 26, 2022
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2173
Rationale for this change
Follows on from #2310 and applies the same treatment to HashJoinExec
What changes are included in this PR?
Extract the common futures shenanigans into a
OnceAsyncand then uses this within both CrossJoinExec and HashJoinExecAre there any user-facing changes?
HashJoinExec no longer evaluates during the plan