Skip to content

Add EXISTS and IN subquery rewriting for correlated filters at filter depth 1 #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jon-chuang wants to merge 10 commits into from
Closed

Add EXISTS and IN subquery rewriting for correlated filters at filter depth 1 #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6b44853
add exists subquery rewriting and correlated filters at filter depth 1
jon-chuang May 5, 2022
99ae035
minor
jon-chuang May 5, 2022
066a865
clippy
jon-chuang May 5, 2022
3476819
minor
jon-chuang May 6, 2022
781e76a
move to utils
jon-chuang May 6, 2022
2c20e5d
minor
jon-chuang May 6, 2022
c968082
more rewriting
jon-chuang May 7, 2022
1e64c5e
rewrite correlated columns util
jon-chuang May 7, 2022
c1d71b5
clippy
jon-chuang May 7, 2022
e7f0365
move more to utils
jon-chuang May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion/core/src/optimizer/filter_push_down.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ fn issue_filters(
return push_down(&state, plan);
}

let plan = utils::add_filter(plan.clone(), &predicates);
let plan = utils::filter_by_all(plan.clone(), &predicates);

state.filters = remove_filters(&state.filters, &predicate_columns);

Expand Down Expand Up @@ -251,7 +251,7 @@ fn optimize_join(
Ok(plan)
} else {
// wrap the join on the filter whose predicates must be kept
let plan = utils::add_filter(plan, &to_keep.0);
let plan = utils::filter_by_all(plan, &to_keep.0);
state.filters = remove_filters(&state.filters, &to_keep.1);

Ok(plan)
Expand Down Expand Up @@ -290,7 +290,7 @@ fn optimize(plan: &LogicalPlan, mut state: State) -> Result<LogicalPlan> {
// As those contain only literals, they could be optimized using constant folding
// and removal of WHERE TRUE / WHERE FALSE
if !no_col_predicates.is_empty() {
Ok(utils::add_filter(
Ok(utils::filter_by_all(
optimize(input, state)?,
&no_col_predicates,
))
Expand Down
Loading