LogicalPlanBuilder now uses TableSource instead of TableProvider
#2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
May 18, 2022
|
|
||
| //! This module provides a builder for creating LogicalPlans | ||
| use crate::datasource::TableProvider; |
Member
Author
There was a problem hiding this comment.
This was the main objective - removing one of the final dependencies from LogicalPlanBuilder to the "core" datafusion crate.
andygrove
changed the title
LogicalPlanBuilder now uses TableSource instead of TableProviderLogicalPlanBuilder now uses TableSource instead of TableProvider
alamb
approved these changes
May 21, 2022
| pub fn scan_with_filters( | ||
| table_name: impl Into<String>, | ||
| provider: Arc<dyn TableProvider>, | ||
| table_source: Arc<dyn TableSource>, |
Contributor
There was a problem hiding this comment.
I wonder if we could make the APIs a little (avoid having to call provider_as_source) nicer with something like
Untested:
table_source: impl Into<Arc<dyn TableSource>>
Or add some other trait that would allow us to pass both Arc<dyn TableSource> as well as Arc<dyn TableProvider>
I think we can always refine the API in a follow on PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2346
Rationale for this change
SQL planner should use TableSource not TableProvider since there is no need to actually perform scans during planning and this would be a step towards moving the SQL planner into its own crate so we have cleaner dependency management.
What changes are included in this PR?
Use TableSource not TableProvider.
Are there any user-facing changes?
Yes, API change.